Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prettier rules and next core web vitals linting added to .eslintrc #107

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

atepem
Copy link
Collaborator

@atepem atepem commented Sep 30, 2024

Proposed changes

Added overall linter using next/core-web-vitals and prettier rules that fixes formatting on save (same settings applied on olas website). All apps and files have been fixed using yarn nx lint --fix [appname].

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
launch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 0:16am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
bond ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 0:16am
govern ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 0:16am
operate ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 0:16am
registry ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 0:16am

Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

.vscode/settings.json Show resolved Hide resolved
.eslintrc.json Show resolved Hide resolved
@atepem atepem merged commit a1bf4aa into main Oct 1, 2024
12 checks passed
@atepem atepem deleted the precious/update-linter branch October 1, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants